Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 18 airflow tweaks #19

Closed
wants to merge 3 commits into from
Closed

Feature 18 airflow tweaks #19

wants to merge 3 commits into from

Conversation

chriscauley
Copy link
Collaborator

Fixes #18

evansiroky
evansiroky approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@evansiroky evansiroky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, but I didn't see the UnconfiguredEnvironment class used anywhere.

gtfs_aggregator_checker/transitland.py
Comment on lines +32 to +35
class UnconfiguredEnvironment(Exception):
"""base class for new exception"""

pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used anywhere?

@atvaccaro
Copy link
Contributor

going to open a new PR

@atvaccaro atvaccaro closed this Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evansiroky evansiroky evansiroky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changes to work with airflow dag
3 participants
@chriscauley @atvaccaro @evansiroky