-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to v5.0.0 of the schedule validator #3314
Conversation
Warehouse report 📦 DAGLegend (in order of precedence)
|
…om:cal-itp/data-infra into vb-3305-gtfs-schedule-validator-v50-update
I initially used a past date but changed to a future date, by @SorenSpicknall 's logic:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tentatively approving because suggested changes are not logic-breaking
Description
Updates to v5.0.0 of the schedule validator. Though the documentation here mentions breaking changes, from my investigation I don't believe it will affect any of our codebase so I simply mirrored a previous pr.
Resolves #3305
Type of change
How has this been tested?
docker-compose run airflow tasks test download_gtfs_schedule_v2 download_schedule_feeds 2024-03-22T00:00:00
docker-compose run airflow tasks test create_external_tables validation_notices 2024-03-22T18:00:00
Did manage to create new tables at
cal-itp-data-infra-staging.external_gtfs_schedule.validation_notices
and see v5.0.0 version with this query:SELECT distinct(metadata.gtfs_validator_version) FROM cal-itp-data-infra-staging.external_gtfs_schedule.validation_notices LIMIT 1000
Did not test with DBT yet.
Post-merge follow-ups
Check if we see v5 validation errors in a few days.
Make sure the new dockerfile image gets pushed to production.