Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearchitect ProgramType logic to be more robust #521

Open
4 tasks
lomky opened this issue Oct 19, 2021 · 0 comments
Open
4 tasks

Rearchitect ProgramType logic to be more robust #521

lomky opened this issue Oct 19, 2021 · 0 comments
Labels
Engineering Technology and Development Track Type: Robustness Tickets to improve the application, invisibly
Milestone

Comments

@lomky
Copy link
Contributor

lomky commented Oct 19, 2021

Description

At the moment the knowledge of ProgramTypes lives in two places:

  • utils/getClaimDetails.ts - who needs to know which to display, a simple list
  • getScenarioContent - who needs it to determine BYE scenarios: UI, PUA, DUA, the federal extentions, or other.

DRY up this code to avoid duplication of the lists of ProgramTypes. We want to avoid narrowly tailoring, as well, in case we later need to analyze Program Types in another way.

Acceptance Criteria

  • There is one canonical list of Program Types
  • Claim Details can show the Program Type
  • Scenario Content can determine BYE
  • Program types can be analyzed another way, if needed for future scenarios, without a large refactor
@lomky lomky added the Engineering Technology and Development Track label Oct 19, 2021
@lomky lomky added this to the For Handoff milestone Oct 19, 2021
@rocketnova rocketnova modified the milestones: For Handoff, Low Priority Dec 8, 2021
@lomky lomky added Type: User Experience Tickets that directly improve the application, visibly Type: Robustness Tickets to improve the application, invisibly and removed Type: User Experience Tickets that directly improve the application, visibly labels Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Technology and Development Track Type: Robustness Tickets to improve the application, invisibly
Projects
None yet
Development

No branches or pull requests

2 participants