Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further restrict valid appointment time slot ranges #351

Open
1 task
rocketnova opened this issue Jul 30, 2021 · 1 comment
Open
1 task

Further restrict valid appointment time slot ranges #351

rocketnova opened this issue Jul 30, 2021 · 1 comment
Labels
Engineering Technology and Development Track Size: S Type: Robustness Tickets to improve the application, invisibly
Milestone
Low Priority

Comments

@rocketnova
Copy link
Contributor

rocketnova commented Jul 30, 2021 •
edited by lomky
Loading

Description

Right now, the appointment time slot start time and end times are valid if they are integers between 1–12. We are assuming that 8–11 is a.m., 12 is p.m., and 1–7 is p.m.

We are not currently restricting the start time to be earlier in the day from the end time, so you can end up with nonsense time slots.

See #345 (comment)

Acceptance Criteria

  • Implement even more restricted validation on the time slot range
@rocketnova rocketnova added the Engineering Technology and Development Track label Jul 30, 2021
@rocketnova rocketnova mentioned this issue Jul 30, 2021
Merged
@rocketnova rocketnova changed the title Decide whether to further restrict valid appointment time slot ranges Further restrict valid appointment time slot ranges Aug 10, 2021
@rocketnova
Copy link
Contributor Author

We discussed this at Eng Sync today and agreed this would be a nice to have, but does not need to be part of any of our current milestones.

@lomky lomky added this to the Low Priority milestone Sep 14, 2021
@lomky lomky added Type: User Experience Tickets that directly improve the application, visibly Type: Robustness Tickets to improve the application, invisibly and removed Type: User Experience Tickets that directly improve the application, visibly labels Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Engineering Technology and Development Track Size: S Type: Robustness Tickets to improve the application, invisibly
Projects
None yet
Milestone
Low Priority
Development

No branches or pull requests
3 participants
@rocketnova @kalvinwang @lomky