Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate json strings on build #338

Open
lomky opened this issue Jul 26, 2021 · 0 comments
Open

Validate json strings on build #338

lomky opened this issue Jul 26, 2021 · 0 comments
Labels
Engineering Technology and Development Track Size: L Type: Robustness Tickets to improve the application, invisibly
Milestone
Low Priority

Comments

@lomky
Copy link
Contributor

lomky commented Jul 26, 2021 •
edited
Loading

Right now we read strings our of our i18n locale files and our urls.json file. The code does not know whether these strings exist, leaving us with a bunch of || null types.

We know all of the lookups at build time, so we should be able to validate that!

This is not a requirement for any part of MVP launch.

Reference: @rocketnova in #333 (comment)
@lomky lomky added the Engineering Technology and Development Track label Jul 26, 2021
@lomky lomky mentioned this issue Aug 19, 2021
Merged
3 tasks
@lomky lomky added this to the Low Priority milestone Sep 14, 2021
@lomky lomky added the Type: Robustness Tickets to improve the application, invisibly label Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Engineering Technology and Development Track Size: L Type: Robustness Tickets to improve the application, invisibly
Projects
None yet
Milestone
Low Priority
Development

No branches or pull requests
2 participants
@kalvinwang @lomky