Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong start position for progress bar #231

Open
cadeyrn opened this issue Sep 7, 2023 · 3 comments
Open

wrong start position for progress bar #231

cadeyrn opened this issue Sep 7, 2023 · 3 comments
Labels
Milestone

Comments

@cadeyrn
Copy link
Owner

cadeyrn commented Sep 7, 2023

The progress bar has a wrong start position. Users with many bookmarks may see the progress bar only after a little time has passed.

Bildschirmfoto 2023-09-07 um 13 28 21
@cadeyrn cadeyrn added the bug label Sep 7, 2023
@cadeyrn cadeyrn added this to the Version 4.2.0 milestone Sep 7, 2023
@BUZZARDGTA
Copy link

BUZZARDGTA commented Sep 23, 2023

image

It seems to me that the progress bar is displaying less then it should, see above screenshot for details...
In the screenshot above, I have 6,7K bookmarks but BO's progress bar displays at the begining like if I had 7k+ bookmarks.

Also it's not that of a big issue...
Probably the problem is related to how the progress is displayed in it's script between the different scanning threads?

@BUZZARDGTA
Copy link

BUZZARDGTA commented Sep 23, 2023

To fix it idk how your code is currently managed but I suggest making a variable used within all the scripts that updates the progress bar, in the internal extension storage, and so you have the right progression to display all the time.

@cadeyrn
Copy link
Owner Author

cadeyrn commented Sep 24, 2023

The progress is calculated after each checked bookmark, and I am not aware of any issues with that. But as described in the issue's description, the start position of the progress bar is wrong. Therefore, the sections in your visualization are probably a bit too short.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants