Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update write_solution method so it writes from Unit Operations directly instead of using ida.ouput #13

Open
daklauss opened this issue Sep 10, 2024 · 0 comments
Assignees

Comments

@daklauss
Copy link
Member

As for now the solution recorder initializes with creating a dictionary-array structure that resembles the the state structure, so it is possible to iterate over the the solution output of ida(s). It may be better to write the solution from the saved state of the unit operation after ida calculated each y instead of after ida calculated each section.

Possible advantages:

  • coupling of calculated state?
  • no need of initializing the solution structure
    Open questions:
  • When to write the solution?
    • IDA may calculate more steps than our given time resolution depending on stifness
    • can't write everytime _compute_residual is called or have to filter much?
  • Consider using step instead of solve to iterate ourself over the give time resolution
@schmoelder schmoelder changed the title Updating Write solution method so it writes from Unit Operations directly instead of using ida.ouput Update write_solution method so it writes from Unit Operations directly instead of using ida.ouput Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants