Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve parameter checks and error messages before running a simulation #28

Open
3 tasks
schmoelder opened this issue Mar 10, 2020 · 1 comment · May be fixed by #109
Open
3 tasks

Improve parameter checks and error messages before running a simulation #28

schmoelder opened this issue Mar 10, 2020 · 1 comment · May be fixed by #109
Labels
bug interface

Comments

@schmoelder
Copy link
Contributor

schmoelder commented Mar 10, 2020 •
edited
Loading

Before running a simulation, parameters could be checked for sanity (e.g. correct sizes and plausible values).

Furthermore, after the simulation, simulation results could be checked (e.g., mass balance checks out).

Tools like this could be implemented in CADET-core or in higher level tools like CADET-Process

List of known issues:
@schmoelder schmoelder changed the title Implement linting tool Improve parameter checks and error messages before running a simulation Nov 17, 2021
@schmoelder schmoelder linked a pull request Jan 18, 2022 that will close this issue
Draft
@schmoelder schmoelder mentioned this issue Jan 31, 2022
Merged
@jazib-hassan-juelich
Copy link
Contributor

jazib-hassan-juelich commented Feb 9, 2022 •
edited
Loading

Before running a simulation, following check should be included:

  • check the conistency between the last entries in the root.input.solver.sections.section_times and root.input.solver.user_solution_times. Any inconsistency between these two values can result in a failing simulation.

This should be included in the CADET core

@jazib-hassan-juelich jazib-hassan-juelich pinned this issue Feb 9, 2022
@lieres lieres unpinned this issue Mar 23, 2023
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Aug 14, 2023
@schmoelder
Disable polynomial flow_rate_filter
9762969 
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Aug 15, 2023
@schmoelder
Disable polynomial flow_rate_filter
2a24ac0 
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Aug 17, 2023
@schmoelder
Disable polynomial flow_rate_filter
428a45f 
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Aug 18, 2023
@schmoelder
Disable polynomial flow_rate_filter
4943738 
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Aug 18, 2023
@schmoelder
Disable polynomial flow_rate_filter
08121b5 
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Aug 29, 2023
@schmoelder
Disable polynomial flow_rate_filter
ccca132 
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Aug 29, 2023
@schmoelder
Disable polynomial flow_rate_filter
caa8389 
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Aug 29, 2023
@schmoelder
Disable polynomial flow_rate_filter
8ba99af 
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Sep 1, 2023
@schmoelder
Disable polynomial flow_rate_filter
6811838 
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Sep 4, 2023
@schmoelder
Disable polynomial flow_rate_filter
37e243a 
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Sep 4, 2023
@schmoelder
Disable polynomial flow_rate_filter
3053b2e 
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Sep 4, 2023
@schmoelder
Disable polynomial flow_rate_filter
41e8b3f 
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Sep 4, 2023
@schmoelder
Disable polynomial flow_rate_filter
a299460 
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Sep 7, 2023
@schmoelder
Disable polynomial flow_rate_filter
fe56c0b 
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Sep 7, 2023
@schmoelder
Disable polynomial flow_rate_filter
1dc422b 
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Sep 7, 2023
@schmoelder
Disable polynomial flow_rate_filter
a179ddf 
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Sep 7, 2023
@schmoelder
Disable polynomial flow_rate_filter
d5e05f1 
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Sep 9, 2023
@schmoelder
Disable polynomial flow_rate_filter
768bde2 
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Sep 9, 2023
@schmoelder
Disable polynomial flow_rate_filter
f60eae9 
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
schmoelder added a commit to fau-advanced-separations/CADET-Process that referenced this issue Oct 16, 2023
@schmoelder
Disable polynomial flow_rate_filter
b0b61d1 
This is currently not supported by CADET-Core.

See [cadet/CADET-Core#28].
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug interface
Projects
CADET-Project
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve parameter checks for flowrate_filter cadet/CADET-Core
3 participants
@schmoelder @jazib-hassan-juelich @jbreue16