Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate nixpkgs-unstable bumps #2

Open
domenkozar opened this issue Apr 15, 2024 · 6 comments
Open

Automate nixpkgs-unstable bumps #2

domenkozar opened this issue Apr 15, 2024 · 6 comments

Comments

@domenkozar
Copy link
Member

domenkozar commented Apr 15, 2024

Depends on cachix/devenv#1088

  • get latest nixpkgs-unstable channel
  • apply our patches
  • run all tests
  • bump rolling
@vetsin
Copy link

vetsin commented Jun 24, 2024

This seems nice, as this branch is months behind

@azerbe
Copy link

azerbe commented Jun 26, 2024

+1 here. A bit too far behind for my taste.

@domenkozar
Copy link
Member Author

The reason why it's behind is because there's a Python fix that we need that has been reverted on nixpkgs master.

We're looking into how to fix it and as soon as it hits nixpkgs the rolling branch can go on.

See https://discourse.nixos.org/t/how-to-build-python-virtualenv-with-packages-provided-by-python3-withpackages/24766/20 for recent discussion.

@domenkozar
Copy link
Member Author

domenkozar commented Jul 10, 2024

WIP at NixOS/nixpkgs#326094, I'm happy to sponsor this work if someone wants to pick it up.

@vlaci
Copy link

vlaci commented Sep 27, 2024

Isn't a viable alternative workaround for devenv to "lift" the python wrapping code from the related PR?

Then at least, it can continue to function the same way as before. I know the current version is suboptimal, but it shouldn't be worse than what is already in devenv's default nixpkgs.

E.g: cachix/devenv@main...vlaci:devenv:python-wrapper

vlaci added a commit to onekey-sec/unblob that referenced this issue Sep 30, 2024
Devenv[^1] is tool to create easily composable development
environments for nix.

Hooking it in to our nix flake gives us the following improvements:
 - more declarative python environment config
 - avoid the `patchElf` hack to pull in native dependencies
 - python packages updates won't undo the effect of `patchElf`
 - due to a long-standing bug[^2], a patched `devenv` version is needed

[^1]: https://devenv.sh/
[^2]: cachix/devenv-nixpkgs#2
vlaci added a commit to onekey-sec/unblob that referenced this issue Sep 30, 2024
Devenv[^1] is tool to create easily composable development
environments for nix.

Hooking it in to our nix flake gives us the following improvements:
 - more declarative python environment config
 - avoid the `patchElf` hack to pull in native dependencies
 - python packages updates won't undo the effect of `patchElf`
 - due to a long-standing bug[^2], a patched `devenv` version is needed

[^1]: https://devenv.sh/
[^2]: cachix/devenv-nixpkgs#2
vlaci added a commit to onekey-sec/unblob that referenced this issue Sep 30, 2024
Devenv[^1] is tool to create easily composable development
environments for nix.

Hooking it in to our nix flake gives us the following improvements:
 - more declarative python environment config
 - avoid the `patchElf` hack to pull in native dependencies
 - python packages updates won't undo the effect of `patchElf`
 - due to a long-standing bug[^2], a patched `devenv` version is needed

[^1]: https://devenv.sh/
[^2]: cachix/devenv-nixpkgs#2
vlaci added a commit to onekey-sec/unblob that referenced this issue Sep 30, 2024
Devenv[^1] is tool to create easily composable development
environments for nix.

Hooking it in to our nix flake gives us the following improvements:
 - more declarative python environment config
 - avoid the `patchElf` hack to pull in native dependencies
 - python packages updates won't undo the effect of `patchElf`
 - due to a long-standing bug[^2], a patched `devenv` version is needed

[^1]: https://devenv.sh/
[^2]: cachix/devenv-nixpkgs#2
vlaci added a commit to onekey-sec/unblob that referenced this issue Sep 30, 2024
Devenv[^1] is tool to create easily composable development
environments for nix.

Hooking it in to our nix flake gives us the following improvements:
 - more declarative python environment config
 - avoid the `patchElf` hack to pull in native dependencies
 - python packages updates won't undo the effect of `patchElf`
 - due to a long-standing bug[^2], a patched `devenv` version is needed

[^1]: https://devenv.sh/
[^2]: cachix/devenv-nixpkgs#2
@domenkozar
Copy link
Member Author

Thanks @vlaci, I've been too focused on upstreaming that PR.

Let's try this at cachix/devenv#1489

vlaci added a commit to onekey-sec/unblob that referenced this issue Oct 2, 2024
Devenv[^1] is tool to create easily composable development
environments for nix.

Hooking it in to our nix flake gives us the following improvements:
 - more declarative python environment config
 - avoid the `patchElf` hack to pull in native dependencies
 - python packages updates won't undo the effect of `patchElf`
 - due to a long-standing bug[^2], a patched `devenv` version is needed

The `.devenv` directory is pre-created because of a quirk: it needs to
be present in the `src` derivation of `shell.nix`, otherwise it is
unable to create it due to a permission error.

[^1]: https://devenv.sh/
[^2]: cachix/devenv-nixpkgs#2
vlaci added a commit to onekey-sec/unblob that referenced this issue Oct 4, 2024
Devenv[^1] is tool to create easily composable development
environments for nix.

Hooking it in to our nix flake gives us the following improvements:
 - more declarative python environment config
 - avoid the `patchElf` hack to pull in native dependencies
 - python packages updates won't undo the effect of `patchElf`
 - due to a long-standing bug[^2], a patched `devenv` version is needed

The `.devenv` directory is pre-created because of a quirk: it needs to
be present in the `src` derivation of `shell.nix`, otherwise it is
unable to create it due to a permission error.

[^1]: https://devenv.sh/
[^2]: cachix/devenv-nixpkgs#2
vlaci added a commit to onekey-sec/unblob that referenced this issue Oct 4, 2024
Devenv[^1] is tool to create easily composable development
environments for nix.

Hooking it in to our nix flake gives us the following improvements:
 - more declarative python environment config
 - avoid the `patchElf` hack to pull in native dependencies
 - python packages updates won't undo the effect of `patchElf`
 - due to a long-standing bug[^2], a patched `devenv` version is needed

The `.devenv` directory is pre-created because of a quirk: it needs to
be present in the `src` derivation of `shell.nix`, otherwise it is
unable to create it due to a permission error.

[^1]: https://devenv.sh/
[^2]: cachix/devenv-nixpkgs#2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants