Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Cables editor should not take over TAB key by default #931

Open
TobyKLight opened this issue Nov 27, 2024 · 3 comments
Open

Comments

@TobyKLight
Copy link
Contributor

Currently the cables.gl editor uses TAB to open the 'create op' dialog.

Obviously this is a standard hotkey now in use by a lot of cables.gl users, but unfortunately TAB is one of the core keyboard functions needed for accessibility, normally cycling through all the interactive elements on a page.

This series of feature requests is not about making the cables editor more accessible per se. BUT having TAB blocked makes extra friction if you want to test that the patch you make in cables.gl is itself accessible. You have to open it in a different window to test accessibility which is annoying.


Proposal:

  • TAB for opening the 'create op' dialog is grandfathered and made an option in user account.
  • Existing users keep existing functionality, can disable it from user account settings.
  • New users have it disabled by default.
@TobyKLight TobyKLight added the new label Nov 27, 2024
@pandrr
Copy link
Member

pandrr commented Nov 28, 2024

this is already gone on dev.cables.gl

there is now an input field for the opselect key.
by default it is only "escape" it can be set as "escape,tab"

more possibilities for user to define keybindings will be added and improved in the future

@pandrr pandrr added done and removed new labels Nov 28, 2024
@pandrr
Copy link
Member

pandrr commented Nov 28, 2024

also on dev.cables.gl in modal dialogs you can now use the tab key to navigate buttons. we will improve on all of this

@steam0r
Copy link
Collaborator

steam0r commented Dec 17, 2024

this made it to cables.gl with the latest release, just now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants