Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoothing op: Increase and Decrease reversed? #899

Open
strangerattractor opened this issue Nov 7, 2024 · 3 comments
Open

smoothing op: Increase and Decrease reversed? #899

strangerattractor opened this issue Nov 7, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@strangerattractor
Copy link

image

Check Image above:
Pink Line is unsmoothed average volume
green line is attack and release smoothed

yellow line is attack raw, decreasing values smoothed. but to get that effect I have to set the Inc factor to 4 and the dec factor to 0.
That is very counter intuitive, especially compared to the "both smoothed" setting. I would expect it the other ways around.

Also: Setting inc factor to 0 crashes the op without debug note. I need to reload the patch completely to make it work again.

Demo Patch here:
https://cables.gl/edit/6Fmgrt

@strangerattractor strangerattractor added bug Something isn't working new labels Nov 7, 2024
@steam0r steam0r removed the new label Nov 11, 2024
@pandrr
Copy link
Member

pandrr commented Nov 11, 2024

how do you get a crash ? does not crash for me

0 is a wrong value for a factor basically, we could show a warning....

@pandrr
Copy link
Member

pandrr commented Nov 11, 2024

works fine when chaniging from 0 to another number, just have to reset vizGraph

@strangerattractor
Copy link
Author

Ah I see, makes sense.

In that case:
Feature Request:
A reset trigger on the smooth op would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants