-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a step to update study metadata #67
Comments
Not sure if this sounds silly, but perhaps allowing for update of any meta file, especially description as perhaps if a clarifying detail needed to be added about the nature of any of the clinical data files or the genomic files, one could easily patch that rather than having to reload the entire study. |
@migbro I’ve realized that including the update of study attributes as part of incremental upload doesn’t make much sense. Incremental upload operates within the patient-sample hierarchy, where entities and their child entities are removed and reloaded based on the supplied files. For example, when incrementally uploading patients, all their associated samples are removed and reloaded. Following this logic, applying incremental upload to studies would require removing all patients and their samples when a study is incrementally uploaded. This essentially mirrors the behavior of a full reload, which defeats the purpose of incremental uploads. This is why incremental upload for studies was not supported in the first place. That said, we could implement study attribute updates as a separate update or patch command. By the way, is there a description field in clinical meta files currently? I couldn’t find one. All platform-based molecular data types share the following fields in their meta files: |
@migbro When updating a study's metadata, how should the absence of an attribute be interpreted? Should the missing attribute be removed, or should it remain unchanged? For example, consider study A, which initially included a |
It won't be possible to update |
Not sure how to deal with |
Honestly, I was more concerned with, when a meta file has a description filed, or as you pointed out a citation field, being able to update that. Even just say, replacing a complete meta file is fine, it's the hope of avoiding reloading the whole study when all you wanted to do was update text that provides context or add al link. Other fields, especially in meta_study like |
Here is the implementation #68 |
Add support of update any of the study attributes described in the Meta File Formats Documentation without reloading the entire study.
The text was updated successfully, but these errors were encountered: