Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons AND Arrows? #182

Closed
bobrocke opened this issue Jun 8, 2014 · 7 comments
Closed

Icons AND Arrows? #182

bobrocke opened this issue Jun 8, 2014 · 7 comments

Comments

@bobrocke
Copy link

bobrocke commented Jun 8, 2014

I have ST3 build 3062 and Soda v2014.05.07.06.11.27.

I'm getting both the arrows, which I want AND the little folder icons, which I don't. Like this:

icons

How do I turn off the folder icons? "soda_folder_icons": false, doesn't do it.

@buymeasoda
Copy link
Owner

Sublime Text 3 Build 3062 changed the way folders and files are rendered in the sidebar.

The default ST UI now renders an arrow with folder icon. Soda Theme was updated to work correctly with this change.

As a result, the soda_folder_icons setting was deprecated for ST3, since folders were always on.

There may be ways to work around this change in the upstream UI, but in the short term it was needed to unbreak Soda Theme, particularly with other UI additions like the sidebar folder loading indicators.

Kronuz added a commit to Kronuz/soda-theme that referenced this issue Jun 10, 2014
* Sidebar tree with row_padding of [0, 3]
  Removes extra padding

* Sidebar group closed with content_margin of [0, 8]
  Removes arrows (and leaves just folders)

* Sidebar file icons with content_margin of [0, 8]
  Removes extra padding in files inside folders
  (making them look as if they were a level deeper than they are)
@SergiiD
Copy link

SergiiD commented Sep 17, 2014

    "class": "disclosure_button_control",
    "content_margin": [0,0], //[8, 8],

@SergiiD
Copy link

SergiiD commented Sep 17, 2014

"class": "sidebar_tree",
"indent": 0, // original value is 16

change in Soda Dark 3.sublime-theme file

@buymeasoda
Copy link
Owner

This seems like a great use case for adding a User Theme customisation file to your local config.

More info: https://github.com/buymeasoda/soda-theme/wiki/Theme-customisation

I might add a config toggle and include it in the main theme, but trying to avoid to much deviation from the default Sublime approach.

@wunc
Copy link

wunc commented May 15, 2015

I'm having the same problem in ST3 3083. @SergiiD 's solution in a User Theme customization file removes the arrow icons, but how would I do it the other way around (keep the arrows and remove the folder icons)?

@wunc
Copy link

wunc commented May 15, 2015

Nevermind. Found it here: #188 (comment)

@pradyunsg
Copy link

@buymeasoda How about making the arrows a configurable? Unless of course, it's too specific a case for it.

{
    "class": "disclosure_button_control",
    "settings": ["soda_hide_sidebar_arrows"],
    "content_margin": [0, 8]
},
{
    "class": "disclosure_button_control",
    "settings": ["!soda_hide_sidebar_arrows"],
    "content_margin": [8, 8]
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants