Skip to content
This repository has been archived by the owner on Sep 10, 2024. It is now read-only.

Adding Mime Types for file types #104

Open
informationist opened this issue Apr 13, 2017 · 6 comments
Open

Adding Mime Types for file types #104

informationist opened this issue Apr 13, 2017 · 6 comments
Labels

Comments

@informationist
Copy link

hi. thanks you. my previous issue closed without solution. so i reopen issue. i already filed issue after tested that command with comma. can you give me specific command if its wrong? or tell me how to add all file types at once.

i already tried with/without comma before file this issue. i can't fine the right way. my purpose is to support all file types on links. like jpeg image on this example. let me know if this is wrong setting;

.config supybot.plugins.spiffytitles.mimetypes text/html,image/jpeg

debug log; "unacceptable mime type image/jpeg for url https://blog.imgur.com/wp-content/uploads/2016/01/OeiRVAS.jpg"

@butterscotchstallion
Copy link
Owner

Why would you want to do this? You know images don't have a title, right? What would you even expect that to do?

Also, there is a handler for imgur links

@informationist
Copy link
Author

yes, but images have resolution or size and not all images are on imgur. already that imgur link not returns output. my friends bot gives metadata info about images for example. i dont know what he use

@butterscotchstallion
Copy link
Owner

butterscotchstallion commented Apr 14, 2017

I think what is happening here is that the mime types configuration value is a comma separated list, but maybe the value is not interpreted that way.

This line here: https://github.com/butterscotchstallion/limnoria-plugins/blob/master/SpiffyTitles/plugin.py#L1304 treats the value as a list, but perhaps it is not.

By the way, getting information about images is trivial but it is pretty slow too. I think that's why I never implemented it as a default.

@informationist
Copy link
Author

ok, i already filed this issue about 6 months ago. i can live without it. but if you will fix this, i will use it. there was problem on imgur album links on default mimetype setting also. maybe that was coming from the same reason. thanks you for the best plugin currently. :)

@butterscotchstallion
Copy link
Owner

I think this is pretty easily fixable. I'll try and find some time to get it done. Thank you for your patience.

@informationist
Copy link
Author

you're welcome. thanks in advance. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants