Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the problem with Rlcard environment ? #9

Open
hns007 opened this issue May 6, 2024 · 8 comments
Open

What is the problem with Rlcard environment ? #9

hns007 opened this issue May 6, 2024 · 8 comments

Comments

@hns007
Copy link

hns007 commented May 6, 2024

"Rlcard environment sucks, 50bb pot, wrong pot sizes, wrong action order after flop, I don't know where to start. But it's the only environment I konw out there suitable for this task."

Question 1:
"Wrong pot sizes" refers to a 50bb pot, right?
--- The pot size can be modified through configuration. for example:
rlcard.make(
'no-limit-holdem',
config={
'seed': seed,
'chips_for_each': 200
}
)

Quest 2:
what dose "Wrong action order after flop" mean?

@bupticybee
Copy link
Owner

Even you can set chip number it's not good enough, bet size is different from slumbot, and in flop,BB should move first, but in rlcard env, SB moves first.

@hns007
Copy link
Author

hns007 commented May 7, 2024

OK, thanks. What were the results of the matches between AlphaNLHoldem and Slumbot?

@bupticybee
Copy link
Owner

OK, thanks. What were the results of the matches between AlphaNLHoldem and Slumbot?

Can't play with slumbot, implemted rules are different.

@bluedevils23
Copy link

Even you can set chip number it's not good enough, bet size is different from slumbot, and in flop,BB should move first, but in rlcard env, SB moves first.

In heads-up game,
pre-flop : SB move first.
flop/turn/river/: BB move first.

Seems your web game not following above rule.

@bupticybee
Copy link
Owner

Even you can set chip number it's not good enough, bet size is different from slumbot, and in flop,BB should move first, but in rlcard env, SB moves first.

In heads-up game, pre-flop : SB move first. flop/turn/river/: BB move first.

Seems your web game not following above rule.

I know. It's a simulator bug.

@bluedevils23
Copy link

Even you can set chip number it's not good enough, bet size is different from slumbot, and in flop,BB should move first, but in rlcard env, SB moves first.

In heads-up game, pre-flop : SB move first. flop/turn/river/: BB move first.
Seems your web game not following above rule.

I know. It's a simulator bug.

Thx for your reply, my understanding is your mentioned simulator really means rlcard, is that correct?

@bupticybee
Copy link
Owner

Even you can set chip number it's not good enough, bet size is different from slumbot, and in flop,BB should move first, but in rlcard env, SB moves first.

In heads-up game, pre-flop : SB move first. flop/turn/river/: BB move first.
Seems your web game not following above rule.

I know. It's a simulator bug.

Thx for your reply, my understanding is your mentioned simulator really means rlcard, is that correct?

yeah

@bluedevils23
Copy link

bluedevils23 commented Dec 9, 2024

rlcard dealing order issue can be workarounded by simply editing ~/anaconda3/envs/py36/lib/python3.6/site-packages/rlcard/games/nolimitholdem/game.py

Verified with the web game interface.
playing

diff --git a/rlcard/games/nolimitholdem/game.py b/rlcard/games/nolimitholdem/game.py
index 86276fb..a3f823f 100644
--- a/rlcard/games/nolimitholdem/game.py
+++ b/rlcard/games/nolimitholdem/game.py
@@ -181,6 +181,8 @@ class NolimitholdemGame(Game):
                     self.round_counter += 1
 
             self.round_counter += 1
+            if self.num_players == 2 and self.round_counter >= 1:
+                self.game_pointer = (self.game_pointer + 1) % self.num_players
             self.round.start_new_round(self.game_pointer)
 
         state = self.get_state(self.game_pointer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants