Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifying information regarding SSO experience #269

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Clarifying information regarding SSO experience #269

merged 2 commits into from
Aug 22, 2024

Conversation

jayk-u
Copy link
Contributor

@jayk-u jayk-u commented Aug 5, 2024

Quick clarification on how SSO login pages work

@jayk-u jayk-u requested review from Polo2 and grossyoan August 5, 2024 12:25
@jayk-u jayk-u self-assigned this Aug 5, 2024
Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for bump-content-hub ready!

Name Link
🔨 Latest commit fbdacd3
🔍 Latest deploy log https://app.netlify.com/sites/bump-content-hub/deploys/66c683c9dd70420008231ad4
😎 Deploy Preview https://deploy-preview-269--bump-content-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@Polo2 Polo2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification,

I left a suggestion about SSO & private Api/Hub

### Operation with Bump.sh

Once the SSO connection(s) are set up, your private documentation or hubs will only be accessible to authenticated users. You will find the link to the SSO login page in the settings of your organization.
This SSO login link redirects to the dashboard.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention that user is redirected to private Hub or Api when it was the expected page before authentication?

And we should advice here to share url of private Api or Hub for guests, if you don't want these users to access dashboard

Copy link
Contributor

@grossyoan grossyoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jay! Thanks for the changes 🙏
We should replace this image with an up-to-date one, showing the new table.
image

Apart from that and the feedback from Polo, LGTM!

@jayk-u jayk-u merged commit e90d705 into main Aug 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants