-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preview: first take to handle bump preview
command 🎉
#8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just left a small comment about OpenAPI version,
while I was reading this whole PR for my education.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a second review, sorry for the ping/pong. I left some important (I think) comments. It's far easier to understand comparing to the first version.
I think that we still can enhance some stuff to make it even clearer.
Another small note: I think that we should try to do atomic PRs when we can. This means extracting any not directly related changes to other smaller PRs. Small/atomic PRs make reviewing a bit easier and merging faster. This is the first one so I totally get why it's a big one, but for the upcoming ones, I'm sure that we can do smaller ones.
Congrats on this huge work, I'm pretty sure that we'll be able to merge something tomorrow! 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some small comments and questions, but nothing that should block this PR (it's more for my personal knowledge and to be sure that it's not stuff you forgot).
You got the LGTM, let's merge this! 👏
This commit re-writes two things: - the way we handle API errors and extracts the logic in the dedicated `APIError` class. - Extract the references builder outside of the 'preview' command in a dedicated generic `Command#prepareDefinition` function.
Thanks for the review (and the patience) 😃 |
This is the implementation of the preview command with a lot of simplification from the original ruby CLI.
It removes:
--specification
flag because the server now knows how to guess from the given file--validation
flag because the server will now only do the'basic'
validation (cf https://github.com/bump-sh/bump/issues/522)--no-external-refs
flag because the new node CLI handles all external refsThe resulting command can be summarised by its help:
🎉
Closes #1