Adds a User-agent header to curl module requests #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The header will be of the form:
peru/{version} Python-urllib/{version}
Fixes buildinspace#218
colindean
commented
Nov 30, 2021
and use a %-format instead of an f-format to maintain compatibility with Python 3.5 since f-format came in 3.6.
This sets the stage for more request modifications.
colindean
added a commit
to colindean/peru
that referenced
this pull request
Dec 1, 2021
When working on buildinspace#219, I found it repetitive to use history to invoke commands when I could just type "make" like I do in many other projects, including my Python projects. I extracted therefrom this minimalistic Makefile and added references to it in CONTRIBUTING. I also cleaned up some markup in CONTRIBUTING.
colindean
commented
Dec 3, 2021
|
It looks like the test failures here are something that changed in Git 2.34. I can repro them on my local machine, but they go away with I downgrade to Git 2.33. Will debug more tomorrow. |
|
I ended up bisecting Git itself to figure out what they heck they changed. Turns out it's this: git/git@491a757. A relatively obscure detail of how |
oconnor663
pushed a commit
that referenced
this pull request
Dec 13, 2021
When working on #219, I found it repetitive to use history to invoke commands when I could just type "make" like I do in many other projects, including my Python projects. I extracted therefrom this minimalistic Makefile and added references to it in CONTRIBUTING. I also cleaned up some markup in CONTRIBUTING.
|
I'll move discussion of the test failure into a new issue: #221 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header will be of the form:
Fixes #218