[raft] SyncRequestDeleteReplica should not ignore ErrShardClosed (#8030)

buildbuddy-io/buildbuddy-internal#4211
buildbuddy-io · Dec 10, 2024 · 955fea7 · 955fea7
1 parent 31a1518
commit 955fea7
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/enterprise/server/raft/store/store.go b/enterprise/server/raft/store/store.go
@@ -1033,11 +1033,7 @@ func (s *Store) syncRequestDeleteReplica(ctx context.Context, rangeID, replicaID
 
 	// Propose the config change (this removes the node from the raft cluster).
 	err = client.RunNodehostFn(ctx, func(ctx context.Context) error {
-		err := s.nodeHost.SyncRequestDeleteReplica(ctx, rangeID, replicaID, configChangeID)
-		if err == dragonboat.ErrShardClosed {
-			return nil
-		}
-		return err
+		return s.nodeHost.SyncRequestDeleteReplica(ctx, rangeID, replicaID, configChangeID)
 	})
 	return err
 }