Tidy up #125
Open
Tidy up #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdSchouten
reviewed
Feb 7, 2024
cmd/bb_worker/main.go
Outdated
| @@ -254,10 +254,10 @@ func main() { | |||
| // used. This increases cache hit rate. | |||
| cacheDirectory, err := filesystem.NewLocalDirectory(nativeConfiguration.CacheDirectoryPath) | |||
| if err != nil { | |||
| return util.StatusWrap(err, "Failed to open cache directory") | |||
| return util.StatusWrapf(err, "Failed to open cache directory: %v", nativeConfiguration.CacheDirectoryPath) | |||
There was a problem hiding this comment.
return util.StatusWrapf(err, "Failed to open cache directory %#v", nativeConfiguration.CacheDirectoryPath)Drop the : and add a #. The # causes the string to be quoted. Same in other places in this PR.
added 4 commits
February 7, 2024 16:41
This is required to build the otel stylesheet on Windows.
stagnation
force-pushed
the
feature/tidy-up-2024-01
branch
2 times, most recently
from
86ef203 to
3b4602b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small changes to I made during the work to update windows workers.
Keep them as a separate PR to merge them sooner, and reduce the scope of the meaty review of the PR.