Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contract resolve does not consider the status of a bug #52

Closed
GeorgLink opened this issue Mar 3, 2018 · 4 comments
Closed

contract resolve does not consider the status of a bug #52

GeorgLink opened this issue Mar 3, 2018 · 4 comments
Labels
0-NEXT_ACTION Next Action! 1-HIGH_PRIORITY This is high priority bug Something isn't working

Comments

@GeorgLink
Copy link
Collaborator

Regardless of whether I set the status of a bug to "closed" or "open", upon 'bmx contract resolve', the same position gets the payout.

How to repeat this issue?
Run trivial bot and change the status of an issue (try both: closed and open) before resolving issues. The payout will always go to the same position holder, which is not the expected behavior.

@andyl
Copy link
Contributor

andyl commented Mar 4, 2018

I note the high priority - I'm on the road and will examine this evening.

Please if possible: add a failing regression test.

Also plz review enhancement request #53 which I think will help to give clarity about system behavior.

@GeorgLink
Copy link
Collaborator Author

@andyl
Copy link
Contributor

andyl commented Mar 7, 2018

Thanks for the PRs with the failing specs.

All CL specs now passing.

@andyl andyl closed this as completed Mar 7, 2018
@GeorgLink
Copy link
Collaborator Author

GeorgLink commented Mar 7, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-NEXT_ACTION Next Action! 1-HIGH_PRIORITY This is high priority bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants