Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update protoplugin example #563

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Update protoplugin example #563

merged 4 commits into from
Sep 25, 2023

Conversation

timostamm
Copy link
Member

@timostamm timostamm commented Sep 25, 2023 •
edited
Loading

  • Update buf.gen.yaml to use the new path syntax added in buf v1.14.0 to make the example run on windows.
  • Add tests for the generated code.
  • Update the documentation for writing plugins with guidance for testing.
  • Update the example package to be self-sufficient and update the README.

@timostamm timostamm marked this pull request as ready for review September 25, 2023 13:48
@timostamm timostamm requested a review from smaye81 September 25, 2023 13:48
emcfarlane
emcfarlane approved these changes Sep 25, 2023
View reviewed changes
Copy link

@emcfarlane emcfarlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@timostamm timostamm merged commit c89f712 into main Sep 25, 2023
2 checks passed
@timostamm timostamm deleted the tstamm/update-protoplugin-example branch September 25, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emcfarlane emcfarlane emcfarlane approved these changes

@smaye81 smaye81 Awaiting requested review from smaye81

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timostamm @emcfarlane