Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for recycling "leaf" connections #60

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Conversation

jhump
Copy link
Member

@jhump jhump commented Feb 28, 2024

Along with #58, this should be the other half of the solution to resolve #59.

This allows the leaf level transports to be periodically re-created. That way, if by chance a single pool ends up in a state of limited diversity (too many transports with persistent connections to the same backend), re-creating the transport will allow it a chance to contact a different backend, and thus be continually changing the mix of target backends.

@jhump jhump marked this pull request as ready for review February 28, 2024 20:43
@jhump
Copy link
Member Author

jhump commented Feb 28, 2024

cc @DMarby

balancer_test.go Show resolved Hide resolved
Copy link
Member

@jchadwick-buf jchadwick-buf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

balancer.go Show resolved Hide resolved
balancer.go Show resolved Hide resolved
@jhump jhump merged commit 7463e81 into main Mar 8, 2024
5 checks passed
@jhump jhump deleted the jh/recycle-conns branch March 8, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better support for layer-4 (TCP) proxies
2 participants