Skip to content
This repository has been archived by the owner on Jul 2, 2023. It is now read-only.

Wrong check for binding and match in consumer configuration validation #134

Open
Raibaz opened this issue Jul 17, 2018 · 0 comments
Open

Comments

@Raibaz
Copy link
Contributor

Raibaz commented Jul 17, 2018

I was trying to move my consumer configuration outside of the code and into the application.yml file, but i stumbled with an issue in configuration validation.

According to the documentation, the following configuration should be valid for a queue consumer:

VehicleConsumer:
    queue: 'vehiclesQueue-it'

But the ConsumerConfigurationImpl class does this check when validating the configuration.

However, the binding and match properties shouldn't be required when binding a consumer to a queue. Adding them to my yml configuration with bogus values makes the validation pass, but IMHO the check should be fixed.

Note: i did some debugging and noted that when loading configuration from a yml file the binding property is populated with an empty Map instead of being null, so the check fails. Thus, to make the validation pass it's sufficient to add the match property to the consumer configurations, but it shouldn't be needed anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant