Ambiguity between multiple wallet views

[pavlenex]

I am sure we're aware of this , but would be good to discuss how we can clean this one up.

Let me try to recap all the views we have first:

1. /funds which you access when you click on the Send on the dashboard.

2. settings/wallet/funds which you access from Settings> On-chain funds which has the functionality
   

3. settings/wallet which is a duplicate of 4. Settings` > On-chain wallet

4. settings/walletwhich you access by Settings > On-chain funds clicking settings icon in the top right.

I think we overcomplicated stuff here.

1. is send
2. is receive
3. 3 and 4 are duplicates and we should remove onchain wallet setting and call this wallet settings

Just to bring things again into perspective:

Every wallet has 4 basic views:

• /Wallet - transaction overview with balance send and receive buttons
• Wallet/Send - sending
• Wallet/Receive - receiving
• Wallet/Settings - for wallet related settings

@dennisreimann I hope outlined this accurently, tbh it was quite tricky as I got lost in the navigation. Do you have any reasoning or ideas how we could tackle this cleanup? Perhaps there are some technical considerations I am missing out here, but I am sure a lot of this is caused by us not knowing specifically how we want to do this, and perhaps overthinking on the receive functionality.

[pavlenex]

It seems @dennisreimann pushed some changes that make most of this issue obsolete now.

However, there are still two wallets for some reason:

1. Dashboard > Send which is lightning + onchain (what we want) but it's dependent on wrong API points causing You need to allow non-admins to use hotwallets for their stores (in /server/policies) #117

2. Settings > On-chain wallet (which seems to be only on-chain wallet) and it works

Ideal solution here is to have a single wallet, that unifies lightning and on-chain, but also works regardless of the server settings, so a combination of both views.

[dstrukt]

Agree, getting the foundation there was very helpful, but the views need to be unified and cleaned up now that they're working as intended!

[dstrukt]

Agree with @pavlenex and see a similar proposal:

1. Wallet (either will be part of the Dashboard tab) or it's own tab

• Includes the Unified Balance
• Lists the latest transactions, possibly invoices
• Send / Receive buttons

2. Wallet/Send - Send view, accessible only through the Wallet

3. Wallet/Receive - Receive view, accessible only through the Wallet, maybe we eventually add Lightning support here, but at the moment, Lightning receive is done through the Keypad

4. Wallet/Settings - for Lightning and On-chain Wallet related Settings

No need for it to be more complicated.