-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Revamp the UI of the leaderboard / dashboard #48
Comments
@Priyansh61 i would like to work on this issue please assign this this issue to me |
@abansal15 Please get your previous PR merged first, then you can work on this |
@Priyansh61 my previous pr has been merged now please assign this issue to me |
@Priyansh61 can you please guide me how to proceed ... |
@abansal15 see the issue description |
@Priyansh61 can you please provide me some resources for making leaderboard attractive as i am facing problem in fetching the details of the people.. |
@abansal15 Let me know your approach how do you think you are going to handle it? |
@Priyansh61 I will change the CSS of the file. But I am facing an issue that in my local host why leaderboard status or data is not coming? |
@abansal15 Could you please show the console logs becuase the leaderboard data is visible in the local dev setup also ? |
@abansal15 Please pull from the upstream |
@Priyansh61 can we change the theme for this page ? |
NO keep it the same since that is global, just change the layout as given in the desciption |
@Priyansh61 ok |
BSOC.-.Google.Chrome.2023-07-11.17-38-53.mp4 |
@Priyansh61 is it ok ? |
@abansal15 I would honestly like to know your own review regarding the changes you made? |
@Priyansh61 I am somewhat confused about the animation I have put into the website and rest i think it is fine and I would be very happy about your reviews and the changes. |
@tushitshukla03 @prernadabi23 @thejaysharma Could you please review the designs and provide the feedback? |
@abansal15
Will these changes be okay, @Priyansh61? |
@prernadabi23 ok i will make the changes |
@prernadabi23 now is it ok ? |
@abansal15 Dont you think the medals look a bit odd? Can we use something else in its place? |
@Priyansh61 can you please suggest me something ? |
Also, just a suggestion, it can be good if the names can be linked to the github links of the accounts?, or just create a new column for the github user-id as suggested in the suggested-layout of the issue. |
@Priyansh61 what is your opinion ? |
what is the use of this ? |
@Priyansh61 I will do what you will guide me ? please guide me on what should i do. |
@Priyansh61 is this image ok ? |
or one more suggestion instead of fancy labels we can just use the images linked with the google account only, if there is no image then google shows the name icon use that. This way it looks elegant and pretty, and then we can just position the images depending on the ranking. |
@Priyansh61 from where I can get the API end point which returns information about the authenticated user, including the profile picture URL. |
In the app we are using google oauth using the function
Buut like currently we dont have this image saved anywhere in the database so this needs to be saved somewhere to be displayed in the database. NOTE : Please dont play with this and let us know your approach before moving forward. I am looping in @prajjwalkapoor @arminpatel @Tusharjain123 @JawHawk to see if there's a better way to do this. |
Ok @Priyansh61 |
@Priyansh61 if you are ok may I raise the pr of only showing the top performers and other ui changes I will currently show the names only and can we create another issue for fetching the profile photo ? |
No this needs to be done in this issue, that's why it is a difficult one |
@Priyansh61 why this is coming in console proxy type when i write console.log(profileImageUrls.value); |
But you didnt extract profile from the google login, so the steps would be like on google login get profile image, save it and then use it. |
@Priyansh61 but i am fetching it from firestore and it stores the url ? |
I couldn't understand. Could you elaborate? |
@Priyansh61 now i am getting only my image url in consoling not others ? |
@Priyansh61 i think i will i not be able to fetch the profile images i have treid my best therefore please create a new issue for fetching the image so that if anyone else can do it . may i only raise the pr of the ui i have made ? |
@abansal15 Will inform in few hours |
@abansal15 @Priyansh61 we have the GitHub username ? Will this work for now then ? |
@JawHawk users are logging from their Google account. I think we don't have their GitHub usernames. |
Then we have to store the google photo when google login Something like this, then we can get the user profile photo link in getCollection I am unfamiliar with the correct way for collections. @Priyansh61 Check if this is okay ? |
Is your feature request related to a problem? Please describe.
Currently the UI of the leaderboard is very simple and not attractive, so we need to make the leaderboard a bit attractive for the users.
Describe the solution you'd like
We can take some inspirations from the GSSoC leaderboard and make it that way, this will make it attractive and also rejuvinating.
Describe alternatives you've considered
No response
Developer Help
No response
The text was updated successfully, but these errors were encountered: