From 3291f42d7b20802fb31f8fa64582fca350cb450b Mon Sep 17 00:00:00 2001 From: John Baldwin Date: Tue, 27 Feb 2024 12:03:26 -0800 Subject: [PATCH] Re-enable fatal linker warnings for programs using netlink netlink no longer uses a zero-length symbol. This reverts commit 3301b01e90274f43a657287fa80c40e8dc85cd6e. This reverts commit 7ec12febfea300340774a0a1156c98c041407a74. This reverts commit 11fa5eced6ecf254100e3f4d4fd0084f3ae98b57. --- libexec/tftp-proxy/Makefile | 3 --- rescue/rescue/Makefile | 3 --- sbin/ifconfig/Makefile | 4 ---- sbin/pfctl/Makefile | 3 --- sbin/route/Makefile | 3 --- tools/cheribsdbox/Makefile | 4 ---- usr.bin/genl/Makefile | 3 --- usr.bin/netstat/Makefile | 4 ---- usr.sbin/arp/Makefile | 3 --- usr.sbin/authpf/Makefile | 3 --- usr.sbin/ftp-proxy/Makefile | 3 --- usr.sbin/ndp/Makefile | 3 --- 12 files changed, 39 deletions(-) diff --git a/libexec/tftp-proxy/Makefile b/libexec/tftp-proxy/Makefile index 52ee90c537ab..88029fae413a 100644 --- a/libexec/tftp-proxy/Makefile +++ b/libexec/tftp-proxy/Makefile @@ -8,9 +8,6 @@ MAN= tftp-proxy.8 CFLAGS+= -I${SRCTOP}/lib/libpfctl -I${OBJTOP}/lib/libpfctl LIBADD= pfctl -# ld.lld: error: could not determine size of cap reloc against local object nla_p_donemsg -LD_FATAL_WARNINGS=no - WARNS?= 3 .include diff --git a/rescue/rescue/Makefile b/rescue/rescue/Makefile index 8140d6d030f7..0283aed9391c 100644 --- a/rescue/rescue/Makefile +++ b/rescue/rescue/Makefile @@ -253,9 +253,6 @@ CRUNCH_ALIAS_chown= chgrp CRUNCH_LIBS+= ${OBJTOP}/lib/libifconfig/libifconfig.a CRUNCH_BUILDOPTS+= CRUNCH_CFLAGS+=-I${OBJTOP}/lib/libifconfig -# ld.lld: error: could not determine size of cap reloc against local object nla_p_donemsg -# >>> defined in libifconfig_carp.c (libifconfig_carp.o:(.rodata+0x1E2C70) -LD_FATAL_WARNINGS= no CRUNCH_LIBS_ifconfig+= ${LIBNV} diff --git a/sbin/ifconfig/Makefile b/sbin/ifconfig/Makefile index 586c239dfd51..b95d7a6ea178 100644 --- a/sbin/ifconfig/Makefile +++ b/sbin/ifconfig/Makefile @@ -76,10 +76,6 @@ SRCS+= ifconfig_netlink.c CFLAGS+=-DWITHOUT_NETLINK .endif -# ld.lld: error: could not determine size of cap reloc against local object nla_p_donemsg -# >>> defined in libifconfig_carp.c (libifconfig_carp.pieo:(.rodata+0x8A10) -LD_FATAL_WARNINGS=no - MAN= ifconfig.8 CFLAGS+= -Wall -Wmissing-prototypes -Wcast-qual -Wwrite-strings -Wnested-externs diff --git a/sbin/pfctl/Makefile b/sbin/pfctl/Makefile index 53d41dd5adb8..c9108f702f29 100644 --- a/sbin/pfctl/Makefile +++ b/sbin/pfctl/Makefile @@ -29,9 +29,6 @@ YFLAGS= LIBADD= m md pfctl -# ld.lld: error: could not determine size of cap reloc against local object nla_p_donemsg -LD_FATAL_WARNINGS=no - HAS_TESTS= SUBDIR.${MK_TESTS}+= tests diff --git a/sbin/route/Makefile b/sbin/route/Makefile index 0fd5adce1324..7685a2fecd64 100644 --- a/sbin/route/Makefile +++ b/sbin/route/Makefile @@ -20,9 +20,6 @@ CFLAGS+= -I. .if ${MK_NETLINK_SUPPORT} != "no" SRCS+= route_netlink.c - -# ld.lld: error: could not determine size of cap reloc against local object nla_p_donemsg -LD_FATAL_WARNINGS=no .else CFLAGS+=-DWITHOUT_NETLINK .endif diff --git a/tools/cheribsdbox/Makefile b/tools/cheribsdbox/Makefile index 48bd970fb91b..7c1d0ce2c02f 100644 --- a/tools/cheribsdbox/Makefile +++ b/tools/cheribsdbox/Makefile @@ -83,10 +83,6 @@ CRUNCH_LIBS+= -lsysdecode CRUNCH_LIBS+= -l80211 CRUNCH_LIBS+= ${CRUNCH_OBJTOP}/lib/libifconfig/libifconfig.a CRUNCH_BUILDOPTS+= CRUNCH_CFLAGS+=-I${CRUNCH_OBJTOP}/lib/libifconfig -# ld.lld: error: could not determine size of cap reloc against local object nla_p_donemsg -# >>> defined in libifconfig_carp.c (libifconfig_carp.o:(.rodata+0xE76D0) -LD_FATAL_WARNINGS=no - # needed by fetch: CRUNCH_LIBS+= -lfetch # devinfo diff --git a/usr.bin/genl/Makefile b/usr.bin/genl/Makefile index b3b9d9a0fa03..15e60300de02 100644 --- a/usr.bin/genl/Makefile +++ b/usr.bin/genl/Makefile @@ -1,6 +1,3 @@ PROG= genl -# ld.lld: error: could not determine size of cap reloc against local object nla_p_donemsg -LD_FATAL_WARNINGS= no - .include diff --git a/usr.bin/netstat/Makefile b/usr.bin/netstat/Makefile index aa291fac6d1a..98bc7b866d9d 100644 --- a/usr.bin/netstat/Makefile +++ b/usr.bin/netstat/Makefile @@ -56,10 +56,6 @@ BINGRP= kmem BINMODE=2555 LIBADD= kvm memstat xo util -# ld.lld: error: could not determine size of cap reloc against local object nla_p_donemsg -# >>> defined in route_netlink.c (route_netlink.o:(.rodata+0xDAC0)) -LD_FATAL_WARNINGS=no - .if ${MK_NETGRAPH_SUPPORT} != "no" SRCS+= netgraph.c LIBADD+= netgraph diff --git a/usr.sbin/arp/Makefile b/usr.sbin/arp/Makefile index afed63433be7..f45319b50810 100644 --- a/usr.sbin/arp/Makefile +++ b/usr.sbin/arp/Makefile @@ -10,9 +10,6 @@ SRCS= arp.c .if ${MK_NETLINK_SUPPORT} != "no" SRCS+= arp_netlink.c - -# ld.lld: error: could not determine size of cap reloc against local object nla_p_donemsg -LD_FATAL_WARNINGS=no .else CFLAGS+=-DWITHOUT_NETLINK .endif diff --git a/usr.sbin/authpf/Makefile b/usr.sbin/authpf/Makefile index f99418a16a58..aa6c6e1058a5 100644 --- a/usr.sbin/authpf/Makefile +++ b/usr.sbin/authpf/Makefile @@ -15,9 +15,6 @@ CFLAGS+= -I${SRCTOP}/lib/libpfctl -I${OBJTOP}/lib/libpfctl LIBADD= m util pfctl -# ld.lld: error: could not determine size of cap reloc against local object nla_p_donemsg -LD_FATAL_WARNINGS=no - WARNS?= 3 LINKS= ${BINDIR}/authpf ${BINDIR}/authpf-noip diff --git a/usr.sbin/ftp-proxy/Makefile b/usr.sbin/ftp-proxy/Makefile index f66ee35674c9..dc7ad7096448 100644 --- a/usr.sbin/ftp-proxy/Makefile +++ b/usr.sbin/ftp-proxy/Makefile @@ -12,9 +12,6 @@ CFLAGS+= -I${SRCTOP}/lib/libpfctl -I${OBJTOP}/lib/libpfctl LIBADD= event1 pfctl -# ld.lld: error: could not determine size of cap reloc against local object nla_p_donemsg -LD_FATAL_WARNINGS=no - WARNS?= 3 .include diff --git a/usr.sbin/ndp/Makefile b/usr.sbin/ndp/Makefile index 7cf518840d51..998860d00a69 100644 --- a/usr.sbin/ndp/Makefile +++ b/usr.sbin/ndp/Makefile @@ -30,9 +30,6 @@ CFLAGS+= -DDRAFT_IETF_6MAN_IPV6ONLY_FLAG .if ${MK_NETLINK_SUPPORT} != "no" SRCS+= ndp_netlink.c - -# ld.lld: error: could not determine size of cap reloc against local object nla_p_donemsg -LD_FATAL_WARNINGS=no .else CFLAGS+=-DWITHOUT_NETLINK .endif