Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppx compilation is broken when used in a library #67

Open
jaredly opened this issue Aug 9, 2018 · 1 comment
Open

ppx compilation is broken when used in a library #67

jaredly opened this issue Aug 9, 2018 · 1 comment

Comments

@jaredly
Copy link
Contributor

jaredly commented Aug 9, 2018

e.g. my app has a dependency, and the dependency is doing a ppx on its own files.
It breaks because npm puts bs-platform in the node_modules directory of the app (b/c it's shared) but the ppx compilation step expects bs_tools_ppx.exe to be in the node_modules of the dependency.

The error:

sh: /[etc etc]/the-project/node_modules/the-library/node_modules/bs-platform/lib/bs_ppx_tools.exe: No such file or directory
@rtsao
Copy link

rtsao commented Oct 28, 2018

This can also be broken with yarn workspace in cases where node_modules are hoisted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants