Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage proxy waits a long time on resolving the unknown domain name #16

Open
canonic-epicure opened this issue Aug 25, 2021 · 1 comment

Comments

@canonic-epicure
Copy link
Collaborator

This kind of test (waiting for an error on resource loading)

t.it('Should support using external URL starting with // as resourceImagePath', async t => {
        let fired;
        const onError = event => {
            t.is(event.target.src, location.protocol + '//foo.bar/bob.jpg');
            fired = true;
        };

        document.body.addEventListener('error', onError, true);

        scheduler = await t.getSchedulerAsync({
            resourceImagePath : '//foo.bar/',
            resources         : [{name : 'Bob'}],
            columns : [{type : 'resourceInfo']}, 1);

        await t.waitFor(() => fired);
        document.body.removeEventListener('error', onError, true);
    });

fails when using code coverage, because (theoretically) the code coverage proxy tries to resolve the foo.bar domain and probably hangs on that, or waits a long time.

@canonic-epicure
Copy link
Collaborator Author

We probably won't be using code coverage proxy, at least for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant