Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark Basemap #789

Closed
ooosssay opened this issue Jul 19, 2024 · 6 comments
Closed

Dark Basemap #789

ooosssay opened this issue Jul 19, 2024 · 6 comments

Comments

@ooosssay
Copy link

A dark basemap would be great to have as sometimes when I am mapping I would switch to mapnik then get flash banged by the white colors so I’d really appreciate having a dark basemap. The only thing I could find a dark mode Mapnik was by inserting css code in a Github issue but I don’t know if that’s possible in an app but at the same time I don’t fully understand what I’m talking about.

@bryceco
Copy link
Owner

bryceco commented Jul 19, 2024

I implemented this in a branch, but haven’t merged it because I thought it needed more feedback. One minor nitpick is that white roads are now black, and other roads have new colors:

image
image

@ooosssay
Copy link
Author

Yeah, the roads look weird but also the buildings and icons may be a little to bright.

@bryceco
Copy link
Owner

bryceco commented Jul 20, 2024

That's using the CSS trick, which isn't the best approach when we have the full power of CoreImage available.

I pushed the branch to https://github.com/bryceco/GoMap/tree/dark-mode-basemap if anyone wants to play with it. The color adjustment is done in https://github.com/bryceco/GoMap/blob/dark-mode-basemap/src/Shared/Utility/DarkModeImage.swift

@bryceco
Copy link
Owner

bryceco commented Jul 20, 2024

This is just reducing the brightness (-40%) of the image:

image

@ooosssay
Copy link
Author

Yeah at that brightness the icons should be good

@bryceco
Copy link
Owner

bryceco commented Jul 22, 2024

Fixed in 1e5ee9f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants