Skip to content
This repository has been archived by the owner on Dec 8, 2019. It is now read-only.

Add function declarations #53

Open
wayne47git opened this issue Apr 17, 2018 · 2 comments
Open

Add function declarations #53

wayne47git opened this issue Apr 17, 2018 · 2 comments

Comments

@wayne47git
Copy link

I'm not real familiar with this development environment but I've been hacking C code for over 40 years and doing embedded systems for 35+.

I've been using Platformio to program my Sonoff devices so used that to build the Multisensor code as well. I needed to declare all the functions to make it compile (and, really, it's just a "good idea" to do that anyway). Suggest adding them:

void callback(char*, byte*, unsigned int);
void reconnect();
bool processJson(char* message);
void setColor(int inR, int inG, int inB);
int calculateVal(int step, int val, int i);
int calculateStep(int prevValue, int endValue);
void loop();
float calculateHeatIndex(float humidity, float temp);
void software_Reset() ;```
@mr-sneezy
Copy link

I've been told that too by better coders than me.
Is that going to help code stability or just speed up compilation ?

@consolacion
Copy link

it doesn't do anything for code stability.
It was necessary til I think IDE 1.6.7 if the functions were in a separate file, but no longer necessary now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants