Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details view stuck at the "Loading please wait" screen for entries with TOTP #351

Open
AdamantGarth opened this issue Jun 26, 2024 · 5 comments

Comments

@AdamantGarth
Copy link

General information

  • Operating system + version: Arch Linux
  • Browser + version: Chromium 126.0.6478.126
  • Information about the host app:
    • How did you install it?
      Via the package manager.
  • Information about the browser extension:
    • How did you install it?
      Via the package manager.
    • Browserpass extension version as reported by your browser: 3.8.0

Exact steps to reproduce the problem

  1. Open the extension popup.

  2. Open the details of an entry that has an otpauth: field.

What should happen?

The entry details are shown.

What happened instead?

The "Loading please wait ..." message is displayed indefinitely.

Additional notes

  • Entries without TOTP work fine.
  • The OTP code gets copied to the clipboard after filling the credentials, so the extension is able to read those entries.
@AdamantGarth
Copy link
Author

AdamantGarth commented Jun 26, 2024

When this happens, Chromium prints the following line to the logs:

INFO:CONSOLE(49256)] "Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'type')", source: chrome-extension://pjmbgaakjkbhpopmakjoedenlfdmcdgm/js/popup.dist.js (49256)

Line 49256 points here, which seems relevant:

login.fields.otp.params.type === "totp"

Edit: the otpauth entry I test this with starts with otpauth://totp/, so the type is there.

@creepiepanda
Copy link

I can confrim this issue on my side with the same error in the console / logs.

OS: Debian 12
Browser: Google Chrome Version 127.0.6533.17 (Official Build) beta (64-bit)
Browserpass: 3.8.0 from chromewebstore

@erayd
Copy link
Collaborator

erayd commented Jun 27, 2024

@AdamantGarth Could you please post the entirety of that line of your password file, with the secret redacted? I suspect the issue is being triggered by the way that line is formatted, and not by TOTP entries generally (testing with totp: SECRETKEY style lines works just fine).

@AdamantGarth
Copy link
Author

Sure, here it is:

otpauth://totp/Google%3Ausername%40gmail.com?secret=redacted&issuer=Google

It also reproduces on entries with otpauth URLs that have all of the optional parameters specified, like:

otpauth://totp/website:username?secret=REDACTED&period=30&digits=6&issuer=website

@jirib
Copy link

jirib commented Dec 8, 2024

@AdamantGarth Could you please post the entirety of that line of your password file, with the secret redacted? I suspect the issue is being triggered by the way that line is formatted, and not by TOTP entries generally (testing with totp: SECRETKEY style lines works just fine).

I think you point to the right thing but it is not clear; what is the format of OTP line needed in the password file, please? See https://github.com/tadfisher/pass-otp?tab=readme-ov-file#migrating-from-pass-otp-01 .

My pass entry format is the following:

<password>
otpauth://totp/<url>%3A<username>?period=30&digits=6&algorithm=SHA1&secret=<secret>&issuer=<issuer>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants