Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monarch link in gene info page does not work #4036

Open
zhanglw05 opened this issue Apr 17, 2024 · 4 comments
Open

monarch link in gene info page does not work #4036

zhanglw05 opened this issue Apr 17, 2024 · 4 comments

Comments

@zhanglw05
Copy link

Hi, Seqr team

the monarch link at the top of gene info page does not work. if you search AGRN in gene info page, the monarch link is set to "https://monarchinitiative.org/ENSEMBL:ENSG00000188157" and this page cannot be opened. Can you please update the link on your repo https://github.com/broadinstitute/seqr/blob/master/ui/shared/components/panel/genes/GeneDetail.jsx#L333 .

@zhanglw05 zhanglw05 added the bug label Apr 17, 2024
@hanars
Copy link
Collaborator

hanars commented Apr 17, 2024

We encourage external groups to provide code fixes to this open source repo whenever possible. If you have already identified exactly where in the code the issue arises and how to fix it, this will be fixed much faster if you provide a pull request with the fix. Otherwise, we will prioritize this fix relative to our other planned seqr work and will get to it in due time

@zhanglw05
Copy link
Author

They are using hgnc id in the url, e.g. https://beta.monarchinitiative.org/HGNC:329. Our fix will be different from yours as we do not have your latest gencc table. you may just change the url to https://beta.monarchinitiative.org/HGNC:{gene.hgnc_id} if hgnc_id is in your gene json.

@hanars
Copy link
Collaborator

hanars commented Apr 17, 2024

we only have hgnc Ids for a tiny small percentage of genes so that is not a valid solution for us eithe

@hanars
Copy link
Collaborator

hanars commented Jun 24, 2024

Blocked on an inability to generate a working link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants