Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues using with phoenix 1.3.0 #53

Open
jmarca opened this issue Aug 31, 2017 · 4 comments
Open

Issues using with phoenix 1.3.0 #53

jmarca opened this issue Aug 31, 2017 · 4 comments

Comments

@jmarca
Copy link

jmarca commented Aug 31, 2017

New to phoenix, trying this out. I see in the README that you are upgrading, so perhaps this bug report is useless, but following along with the README to integrate sentinel with a test phoenix app I have I hit the following warning:

mix phoenix.gen.model is deprecated. Use phx.gen.schema instead.

Looking through the code, it seems this is still in the master branch at https://github.com/britton-jb/sentinel/blob/master/lib/mix/tasks/install.ex#L52.

I'd offer to help out with that, but I'm new to elixir/phoenix and probably would be more noise than signal. (I don't even know how to install the local cloned version of this app in favor of the one from hex.pm, for example)

@britton-jb
Copy link
Owner

@jmarca this is a known issue with 1.3, among others. I'm working on an update, but it's slow in the coming as this is something I do in my free time.

I'd love a hand with improving the generators/install step. You can install the local version by following the format below in your mix.exs

def depedencies do
  ...
  {:sentinel, path: "/path/to/local/sentinel"}
  ...
end

You can likely take inspiration of how to best update the generators by looking at the way Phoenix itself handles them, as the injection method used in 1.3 is likely a much more appropriate way to do it.

If you have any other questions you can reach me here, on the Elixir lang slack @britton, or via the email listed in my GitHub profile.

@britton-jb
Copy link
Owner

In the features/lockable_and_plug branch I'm working on the mostly done, but still in progress 1.3 update.

@jmarca
Copy link
Author

jmarca commented Oct 4, 2017

I'm just "reinventing the wheel", primarily to learn the language and its idioms. If I get competent enough I'll pitch in, but no promises

@britton-jb
Copy link
Owner

I understand, and don't worry about it. I appreciate contributions where possible, but I know that's not always on the table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants