Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check for cutoff for graph traversal for prospective databases #14

Open
muelleram opened this issue Jan 29, 2024 · 2 comments
Open
Labels
not urgent Unessential improvement that can be postponed

Comments

@muelleram
Copy link
Collaborator

The current approach traverses the original database to stop at a certain defined cut-off. It may happen that in a prospective database the production technologies are so different that processes above the cutoff that have a large impact are excluded or processes below the cutoff are included.

@muelleram muelleram changed the title add check for cutoff for graph traversal for propsective databases add check for cutoff for graph traversal for prospective databases Jan 29, 2024
@muelleram muelleram added the not urgent Unessential improvement that can be postponed label Jan 29, 2024
@muelleram
Copy link
Collaborator Author

This could be implemented by calculating a static lca with every time-specific database and then, during the priority-first graph-traversal, inform the cut-off algorithm with most conservative score of each visited node from the set of scores with the different time-specific background databases.

As long as we do not have temporal information in the background, this is not so relevant as we can set the cut-off to very low to make sure we continue the traversal throughout the comparatively short foreground systems to reach the intersection with the background dbs, where we are currently stopping anyways.

@jakobsarthur
Copy link
Collaborator

TODO: add warning to change baseyear database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not urgent Unessential improvement that can be postponed
Projects
None yet
Development

No branches or pull requests

2 participants