Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should the client_name be a unique field? #7

Open
reginafcompton opened this issue Aug 30, 2019 · 0 comments
Open

Should the client_name be a unique field? #7

reginafcompton opened this issue Aug 30, 2019 · 0 comments
Labels
question Further information is requested

Comments

@reginafcompton
Copy link
Contributor

reginafcompton commented Aug 30, 2019 •
edited
Loading

The OAuth2ClientMixin provides a client_name field, but does not mark it as unique.
https://github.com/lepture/authlib/blob/18858b7e84b33dd5dd20b64a664287ba17e0ccd4/authlib/flask/oauth2/sqla.py#L32

I can imagine a Facet user creating clients with the same client name, which could cause confusion, as a DT grows. Should we override the client_name (from OAuth2ClientMixin) in the Authserver modal and mark it as unique?
@reginafcompton reginafcompton added the question Further information is requested label Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reginafcompton