Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVP: User Auth/Heroku #2

Open
4 tasks done
briemcnally opened this issue Apr 5, 2018 · 1 comment
Open
4 tasks done

MVP: User Auth/Heroku #2

briemcnally opened this issue Apr 5, 2018 · 1 comment
Assignees

Comments

@briemcnally
Copy link
Owner

briemcnally commented Apr 5, 2018

  • Users can sign up, sign in, log out
  • Users can use a demo to log in to the site
  • Users can't use certain feature without logging in (making reservations, reviews, and favorites) [This isn't done yet because I don't have those features yet]
  • Pushed to Heroku
@AAlfarho
Copy link
Collaborator

AAlfarho commented Apr 6, 2018

Good job on the user auth, a couple of details.

  • SIgnup component is not displaying errors while trying to create a user.
  • Visiting non-existing routes is not handled yet, accessing /#/not-a-route, should ideally redirect to '/', this is easily done by having a default <Route path="/" ...> at the end of your <Switch>
  • Error display could use some styling, it looks like the reset.css is missing some rules for <li>.
    • Current error display:
      screen shot 2018-04-06 at 9 12 06 am
    • What do you think about having something like:
      screen shot 2018-04-06 at 9 17 10 am
  • We are not clearing out the errors when we unmount the login/signup components.
    • Login with invalid credentials.
    • Navigate to signup.
    • Navigate back to signup, the error still lingers there.

Assign this issue back to me once the updates addressing these issues are live in Heroku.

@AAlfarho AAlfarho assigned briemcnally and unassigned AAlfarho Apr 6, 2018
@briemcnally briemcnally reopened this Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants