Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dummy file to allow bundler to require the gem correctly. #153

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

seuros
Copy link

@seuros seuros commented Feb 4, 2015

No description provided.

@brianmario
Copy link
Owner

Hey @seuros, thanks for the patch! I need to think on it a bit because we were planning on renaming the gem to just yajl but I/we haven't had time to actually make it happen.

@sferik what do you think about this vs the rename? I think I kinda prefer the rename over allowing it be required by it's current name. And I said "vs" because if we allow this and people start requiring it by this, we'll have to leave it in. May not be a bad thing though to make it JustWork with Bundler in either case.

@seuros
Copy link
Author

seuros commented Feb 4, 2015

@brianmario we won't have to leave the file if we rename it in the future. Since the renaming won't be silent upgrade, it the responsibility of the dev to rename any require pointing to old name.

@brianmario
Copy link
Owner

@seuros yeah that's true. Especially if it's just being done in the Gemfile. My concern is for apps that just include it deeper within the stack. Still probably fine.

@sferik
Copy link
Contributor

sferik commented Feb 5, 2015

@sferik what do you think about this vs the rename? I think I kinda prefer the rename over allowing it be required by it's current name. And I said "vs" because if we allow this and people start requiring it by this, we'll have to leave it in.

Agreed. IMHO, #128 is a cleaner solution to this problem.

I need to think on it a bit because we were planning on renaming the gem to just yajl but I/we haven't had time to actually make it happen.

What’s holding this up? Is there anything more I can do to make it happen faster?

@seuros Would renaming the gem be an acceptable solution to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants