Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitions between videos of differing aspect ratio #157

Open
zamirkhan opened this issue Sep 27, 2017 · 0 comments
Open

Transitions between videos of differing aspect ratio #157

zamirkhan opened this issue Sep 27, 2017 · 0 comments

Comments

@zamirkhan
Copy link

zamirkhan commented Sep 27, 2017

First of all, thank you for creating & maintaining Seriously.js - I'm really enjoying using it.

I'm using Seriously.js to perform transitions between videos, very much akin to this example (https://github.com/povdocs/video-transitions). One major difference is that I'm using videos with different aspect ratios (e.g. some 16:9, some 4:3, some 9:16, etc.). I'm using mode='contain' for the reformat object of these videos.

Unfortunately I'm seeing an issue where the 1st video displays correctly, but if the 2nd video has a different aspect ratio, it displays as stretched/squished (depending on the difference). I modified the video-transitions example to use videos of different aspect ratios (and mode='contain' instead of mode='cover') and see the same issue.

The interesting thing is that once the 2nd video is displaying in a distorted fashion, resizing the window will immediately correct the issue (presumably because it invokes the resize handler).

Is there a way to make this work seamlessly, without having to resize the window, or is this a bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant