diff --git a/app/Entities/Controllers/BookshelfController.php b/app/Entities/Controllers/BookshelfController.php index d1b752dc23e..fcfd3753872 100644 --- a/app/Entities/Controllers/BookshelfController.php +++ b/app/Entities/Controllers/BookshelfController.php @@ -30,7 +30,7 @@ public function __construct(BookshelfRepo $shelfRepo, ShelfContext $shelfContext } /** - * Display a listing of the book. + * Display a listing of bookshelves. */ public function index(Request $request) { @@ -111,8 +111,9 @@ public function show(Request $request, ActivityQueries $activities, string $slug ]); $sort = $listOptions->getSort(); - $sortedVisibleShelfBooks = $shelf->visibleBooks()->get() - ->sortBy($sort === 'default' ? 'pivot.order' : $sort, SORT_REGULAR, $listOptions->getOrder() === 'desc') + $sortedVisibleShelfBooks = $shelf->visibleBooks() + ->reorder($sort === 'default' ? 'order' : $sort, $listOptions->getOrder()) + ->get() ->values() ->all(); diff --git a/tests/Entity/BookShelfTest.php b/tests/Entity/BookShelfTest.php index a10a56e9ef3..c1842c175a7 100644 --- a/tests/Entity/BookShelfTest.php +++ b/tests/Entity/BookShelfTest.php @@ -196,6 +196,31 @@ public function test_shelf_view_sort_takes_action() $this->withHtml($resp)->assertElementContains('.book-content a.grid-card:nth-child(3)', 'adsfsdfsdfsd'); } + public function test_shelf_view_sorts_by_name_case_insensitively() + { + $shelf = Bookshelf::query()->whereHas('books')->with('books')->first(); + $books = Book::query()->take(3)->get(['id', 'name']); + $books[0]->fill(['name' => 'Book Ab'])->save(); + $books[1]->fill(['name' => 'Book ac'])->save(); + $books[2]->fill(['name' => 'Book AD'])->save(); + + // Set book ordering + $this->asAdmin()->put($shelf->getUrl(), [ + 'books' => $books->implode('id', ','), + 'tags' => [], 'description' => 'abc', 'name' => 'abc', + ]); + $this->assertEquals(3, $shelf->books()->count()); + $shelf->refresh(); + + setting()->putUser($this->users->editor(), 'shelf_books_sort', 'name'); + setting()->putUser($this->users->editor(), 'shelf_books_sort_order', 'asc'); + $html = $this->withHtml($this->asEditor()->get($shelf->getUrl())); + + $html->assertElementContains('.book-content a.grid-card:nth-child(1)', 'Book Ab'); + $html->assertElementContains('.book-content a.grid-card:nth-child(2)', 'Book ac'); + $html->assertElementContains('.book-content a.grid-card:nth-child(3)', 'Book AD'); + } + public function test_shelf_edit() { $shelf = $this->entities->shelf();