-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using singleton instance on Dart bindings #991
base: flutter_rust_bridge_v2
Are you sure you want to change the base?
Stop using singleton instance on Dart bindings #991
Conversation
Invoke flutter_rust_bridge_codegen without arguments
Generate Dart bindings under lib/generated
fad13f5
to
9a7b4eb
Compare
1f2eb17
to
90eb956
Compare
Use UnsupportedError instead
9a7b4eb
to
797375d
Compare
35d6966
to
ff1697e
Compare
Remove old files
ff1697e
to
26a79ad
Compare
26a79ad
to
6ba9731
Compare
Apply changes on Flutter plugin
6ba9731
to
bb04fa4
Compare
|
||
impl BindingBreezServices { | ||
/// See [BreezServices::sync] | ||
pub async fn sync(&self) -> Result<()> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does using async
functions work for the bindings? Just curious, as previously we block an async call in a sync function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they do. Async Rust code is supported with v2.
Co-authored-by: Ross Savage <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's looking good
Thanks. I'm thinking of writing the migration guide and merging the changes. I'll open an issue for
and address it in scope of another PR. |
dd27d88
to
4b31137
Compare
012b81d
to
3881144
Compare
This PR implements frb v2 Methods support.
connect
now returns aBindingsBreezServices
which we can callBreezServices
API from.TODO:
BreezSDK
wrapper class as a whole, or slim it down as much as possible