Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine cell type #12

Open
Maxxan opened this issue Jul 4, 2017 · 9 comments · May be fixed by #47
Open

Determine cell type #12

Maxxan opened this issue Jul 4, 2017 · 9 comments · May be fixed by #47

Comments

@Maxxan
Copy link

Maxxan commented Jul 4, 2017

It would be very useful to be able to question what cell type something is, if it should be used as a string, number or date, for example to know if xlsxioread_sheet_next_cell_float or some other function should be called.

@brechtsanders
Copy link
Owner

Hi,
Good suggestion. At this time the library just reads data. To know the cell type it will be necessary to keep track of column and row attributes and then check if the cell has a type or inherits it.
I did not intend to do all this, but I will add it to the wish list.
Regards
Brecht

@Maxxan
Copy link
Author

Maxxan commented Jul 4, 2017

I made some modifications to the library to support data types. I could email the file to you and you can see if you want to add it or not.. Then I don't need to make a pull request. :)

@brechtsanders
Copy link
Owner

I would be glad to have a look at you modified code. And if it's good I could include it.

@Maxxan
Copy link
Author

Maxxan commented Jul 4, 2017

Here you are. I fixed a lot of POSIX naming problems as well that generated a lot of warnings.
xlsxio.zip
As you see, I used another library as well for hashmap and array support, but you can do as you want with that. Maybe use an internal solution.

And if you decide to add it, then it should be added to the callback version of reading as well.

@Maxxan Maxxan changed the title Determain cell type Determine cell type Jul 4, 2017
@brechtsanders
Copy link
Owner

Why did you switch from stricmp to _stricmp? In my experience stricmp is more portable, and platform portability remains an important goal of the project. Which platform are you on exactly?

@Maxxan
Copy link
Author

Maxxan commented Jul 5, 2017

Mostly it was due to Visual Studio 2015 giving heaps of warnings about it. :)

@sohguanh
Copy link

sohguanh commented May 2, 2018

May I know this determine cell type feature is available in the latest release? It is quite important as we need to know the datatype before we know which api method to call.

@brechtsanders
Copy link
Owner

This feature is not trivial to implement, and has not been added yet.

@damian-m-g
Copy link

damian-m-g commented Nov 29, 2018

Hi guys. Do we have any chance to see this implemented soon? Do you have any workaround for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants