Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace hashbrown with std::HashMap #69

Closed
rillian opened this issue May 26, 2022 · 0 comments · Fixed by #70
Closed

replace hashbrown with std::HashMap #69

rillian opened this issue May 26, 2022 · 0 comments · Fixed by #70

Comments

@rillian
Copy link
Contributor

rillian commented May 26, 2022

The sharks crate uses hashbrown::HashSet to hold key shares. However, the standard library HashSet has been implemented with hashbrown for a couple of years. If it's just for performance we should be able to drop the external dependency in favour of std::collections::HashSet.

Or switch to Vec for which ZeroizeOnDrop is available, per #30.

Follow-up to #52.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sharks: Use HashSet from std. brave/sta-rs
1 participant
@rillian