Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed generation passes when experiment name is duplicated #818

Open
btlechowski opened this issue Nov 9, 2023 · 2 comments
Open

Seed generation passes when experiment name is duplicated #818

btlechowski opened this issue Nov 9, 2023 · 2 comments
Assignees

Comments

@btlechowski
Copy link

The generation seed job should fail, but it passes.

Then in the client the seed is not applied:


[27107:259:1109/120010.074659:VERBOSE1:processed_study.cc(98)] BraveSearchAdStudy has a repeated experiment name Enabled

cc @atuchin-m @tmancey @iambrianfung

@tmancey tmancey self-assigned this Nov 9, 2023
@tmancey
Copy link
Contributor

tmancey commented Nov 9, 2023

Raised #817 to fix the issue for now. But would be great to detect during seed generation

@btlechowski
Copy link
Author

seed that failed:


        {
            "experiments": [
                {
                    "feature_association": {
                        "enable_feature": [
                            "ShouldAlwaysRunBraveAdsService",
                            "ShouldSupportSearchResultAds",
                            "ShouldAlwaysTriggerBraveSearchResultAdEvents"
                        ]
                    },
                    "name": "Enabled",
                    "probability_weight": 100
                    "probability_weight": 90
                },
                {
                    "feature_association": {
                        "enable_feature": [
                            "ShouldLaunchBraveAdsAsInProcessService",
                            "ShouldAlwaysRunBraveAdsService",
                            "ShouldSupportSearchResultAds",
                            "ShouldAlwaysTriggerBraveSearchResultAdEvents"
                        ]
                    },
                    "name": "Enabled",
                    "probability_weight": 10
                },
                {
                    "name": "Default",
                    "probability_weight": 0
                }
            ],
            "filter": {
                "channel": [
                    "RELEASE"
                ],
                "platform": [
                    "WINDOWS",
                    "MAC",
                    "LINUX",
                    "ANDROID"
                ]
            },
            "name": "BraveSearchAdStudy"
        },

experiment name is duplicated:

"name": "Enabled",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants