Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Custom Notification Ads on release channel for OSes which do not support native notifications #107

Open
btlechowski opened this issue Aug 27, 2021 · 1 comment
Assignees

Comments

@btlechowski
Copy link

Currently ads will not show prior to Windows 10 version 1803, build 17134 and Mac prior to 10.14

We need to enable custom ad notifications so that user start receiving ads again.

Steps:

  1. Clean profile
  2. Run Brave
  3. Wait for variations to be downloaded
  4. Restart Brave
  5. Enable rewards and ads
  6. Trigger an ad

Expected behavior:
Custom Notification Ad is shown
CustomAdNotifications -> can_fallback_to_custom_notifications is enabled

cc @tmancey

@tmancey tmancey self-assigned this Aug 27, 2021
@tmancey tmancey changed the title Enable Custom Notification Ads for Windows older than Windows 10 version 1803, build 17134 and Mac older than 10.14 Enable Custom Notification Ads on release channel for OSes which do not support native notifications Sep 14, 2021
@tmancey
Copy link
Contributor

tmancey commented Sep 14, 2021

@btlechowski speaking with @jsecretan we have decided to also enable custom ad notifications for the following scenarios:

Windows 10 build 16299 and older
Windows 10 build 17134 and newer (fallback if native notifications are disabled, should honor Focus Assist)
macOS 10.13 and older
Android 7 and older
All Linux versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants