[ZCash] Fetch consensus branch id from the backend #27089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+57
to
60
| zcash_wallet_service_->zcash_rpc().GetLightdInfo( | ||
| chain_id, | ||
| base::BindOnce(&ZCashTransactionCompleteManager::OnGetLatestBlockHeight, | ||
| base::BindOnce(&ZCashTransactionCompleteManager::OnGetLightdInfo, | ||
| weak_ptr_factory_.GetWeakPtr(), |
There was a problem hiding this comment.
How frequently branch id changes? Does it make sense to cache it per browser instance, or persist it per network?
There was a problem hiding this comment.
Several times a year i guess, we have to check whether it has been changed anyway
| @@ -334,7 +334,6 @@ void ZCashWalletService::CompleteTransactionDone( | |||
| result.error()); | |||
| return; | |||
| } | |||
|
|
|||
Comment on lines
96
to
109
| std::array<uint8_t, kBlake2bPersonalizationSize> result; | ||
| uint32_t consensusBranchId = tx.consensus_brach_id(); | ||
| base::span(result) | ||
| .subspan(0, sizeof(kTxHashPersonalizerPrefix) - 1) | ||
| .copy_from(base::byte_span_from_cstring(kTxHashPersonalizerPrefix)); | ||
| base::span(result) | ||
| .subspan(sizeof(kTxHashPersonalizerPrefix) - 1, sizeof(consensusBranchId)) | ||
| .copy_from(base::byte_span_from_ref(base::numerics::U32FromLittleEndian( | ||
| base::byte_span_from_ref(consensusBranchId)))); | ||
| return result; | ||
| } | ||
|
|
||
| } // namespace | ||
|
|
There was a problem hiding this comment.
That should be done with SpanWriter
something like
auto span_writer = base::SpanWriter(base::span(result));
span_writer.Write(base::byte_span_from_cstring(kTxHashPersonalizerPrefix));
span_writer.WriteU32LittleEndian(tx.consensus_brach_id())
DCHECK_EQ(span_writer.remaining(), 0u);
| @@ -10,6 +10,7 @@ | |||
| #include <utility> | |||
|
|
|||
| #include "base/containers/span.h" | |||
| #include "base/containers/to_vector.h" | |||
There was a problem hiding this comment.
#include "base/containers/to_vector.h"
|
Released in v1.75.122 |
cypt4
added a commit
that referenced
this pull request
Dec 24, 2024
* [ZCash] Fetch consensus branch id from the backend Resolves brave/brave-browser#42951
cypt4
added a commit
that referenced
this pull request
Dec 25, 2024
* [ZCash] Fetch consensus branch id from the backend Resolves brave/brave-browser#42951
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#42951
Testplan :
Test transparent transactions to be working
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: