Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Webcompat report dialog] Hidden "Send" button if reported URL is too long #27063

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vadimstruts
Copy link
Collaborator

@vadimstruts vadimstruts commented Dec 18, 2024

Resolves brave/brave-browser#42902

Added:

  • ability to enable scroll bar in case of browser window height less then webcompat dialog height
  • shortener for URL displayed on the dialog

Video:

2024-12-18.21-12-23.mp4

Additional Notes:

  • Webcompat Reporter modal dialog content does not receive resize events, so window.onresize doesn't work.
  • overflow-y doesn't work too (on the #root or on the body).

I had to add observing of the OnWidgetBoundsChanged with help of views::WidgetObserver to handle Webcompat Reporter modal dialog resize and show the scrollbar instead of just hiding part of dialog's content, without any possibility to interact with hidden part.
When dialog's content initializes, we send init request to backend to start one iteration of the OnWidgetBoundsChanged and get actual height, to correctly handle the situation, when screen is to small and modal dialog height is greater then screen's. Then if user changes the height of the browser, the OnWidgetBoundsChanged sends correct height to the dialog's content.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Dec 18, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@vadimstruts vadimstruts added the CI/run-macos-x64 Run CI builds for macOS x64 label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-macos-x64 Run CI builds for macOS x64 CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Webcompat report dialog] Hidden "Send" button if reported URL is too long
2 participants