[Webcompat report dialog] Hidden "Send" button if reported URL is too long #27063
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#42902
Added:
Video:
2024-12-18.21-12-23.mp4
Additional Notes:
Webcompat Reporter
modal dialog content does not receive resize events, sowindow.onresize
doesn't work.overflow-y
doesn't work too (on the#root
or on thebody
).I had to add observing of the
OnWidgetBoundsChanged
with help ofviews::WidgetObserver
to handleWebcompat Reporter
modal dialog resize and show the scrollbar instead of just hiding part of dialog's content, without any possibility to interact with hidden part.When dialog's content initializes, we send init request to backend to start one iteration of the
OnWidgetBoundsChanged
and get actual height, to correctly handle the situation, when screen is to small and modal dialog height is greater then screen's. Then if user changes the height of the browser, theOnWidgetBoundsChanged
sends correct height to the dialog's content.Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: