Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Remove Bridge To Aurora Button #27053

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Douglashdaniel
Copy link
Contributor

Description

Remove the Bridge to Aurora button since it is no longer needed.

Resolves brave/brave-browser#42943

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open the Wallet and navigate to the Portfolio screen.
  2. View details for Ethereum.
  3. You should no longer see a Bridge to Aurora button.

Before:

Image

After:

Image

@Douglashdaniel Douglashdaniel self-assigned this Dec 18, 2024
@Douglashdaniel Douglashdaniel requested review from a team as code owners December 18, 2024 00:41
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Dec 18, 2024
Copy link
Contributor

[puLL-Merge] - brave/brave-core@27053

Description

This PR removes the "Bridge to Aurora" feature from the Brave Wallet UI. It deletes related components, styles, localization strings, and utilities associated with this feature.

Changes

Changes

  1. components/brave_wallet/browser/brave_wallet_constants.h:

    • Removed localized strings related to the Aurora modal.
  2. components/brave_wallet_ui/assets/svg-icons/globe-connect-icon.svg:

    • Deleted the SVG icon file associated with the Aurora feature.
  3. components/brave_wallet_ui/components/desktop/popup-modals/bridge-to-aurora-modal/:

    • Removed the entire directory containing the Aurora modal component and its styles.
  4. components/brave_wallet_ui/components/desktop/views/portfolio/portfolio-fungible-asset.tsx:

    • Removed imports, state, and functions related to the Aurora modal.
    • Deleted the "Bridge to Aurora" button and its related logic.
  5. components/brave_wallet_ui/stories/locale.ts:

    • Removed localization strings for the Aurora modal.
  6. components/brave_wallet_ui/utils/asset-utils.ts:

    • Removed the auroraSupportedContractAddresses array.
  7. components/resources/wallet_strings.grdp:

    • Removed string resources related to the Aurora modal.

This sequence diagram illustrates the simplified flow after removing the Aurora bridge feature. The user can still view asset details, but the option to bridge to Aurora is no longer available.```mermaid
sequenceDiagram
participant User
participant BraveWallet
participant AuroraFeature
User->>BraveWallet: View asset details
BraveWallet->>AuroraFeature: Check if asset supports Aurora bridge
AuroraFeature-->>BraveWallet: Feature removed
BraveWallet-->>User: Display asset details without Aurora option

</details>

<!-- Generated by claude-3-5-sonnet-20240620 -->

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Collaborator

@cypt4 cypt4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet puLL-Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Bridge to Aurora Button
4 participants