Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wallet/iOS] Currency symbol in portfolio is not updated after currency is changed in wallet settings #41264

Open
5 tasks
nuo-xu opened this issue Sep 26, 2024 · 0 comments · May be fixed by brave/brave-core#27070
Open
5 tasks

[Wallet/iOS] Currency symbol in portfolio is not updated after currency is changed in wallet settings #41264

nuo-xu opened this issue Sep 26, 2024 · 0 comments · May be fixed by brave/brave-core#27070
Assignees
@nuo-xu
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/exclude

Comments

@nuo-xu
Copy link

nuo-xu commented Sep 26, 2024

Description

Currency symbol in portfolio is not updated after currency is changed in wallet settings

Steps to reproduce

  1. Open wallet
  2. go to wallet settings
  3. change default base currency to something that is not the same as the current one
  4. back to portfolio

Actual result

Currency symbol still display "$" in total balance and balance change label.

Expected result

Currency symbol for total balance and balance change label should reflect the currency change

Reproduces how often

Easily reproduced

Brave version

1.72.x

Device/iOS version

all

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response
@nuo-xu nuo-xu added bug feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality labels Sep 26, 2024
@nuo-xu nuo-xu self-assigned this Sep 26, 2024
@nuo-xu nuo-xu added this to Web3 Sep 26, 2024
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Oct 4, 2024
@nuo-xu nuo-xu linked a pull request Dec 19, 2024 that will close this issue
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nuo-xu nuo-xu

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/exclude
Projects
Web3
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(wallet): fix wallet currency is not updating correctly brave/brave-core
1 participant
@nuo-xu