Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ChromeOS][Follow up to #36190] Passwords can't be synced/enabled on Chromebook #42816

Open
3 of 6 tasks
hffvld opened this issue Dec 11, 2024 · 6 comments · May be fixed by brave/brave-core#27056
Open
3 of 6 tasks

[ChromeOS][Follow up to #36190] Passwords can't be synced/enabled on Chromebook #42816

hffvld opened this issue Dec 11, 2024 · 6 comments · May be fixed by brave/brave-core#27056
Assignees
@AlexeyBarabash
Labels
bug feature/sync OS/ChromeOS QA/Yes

Comments

@hffvld
Copy link
Contributor

hffvld commented Dec 11, 2024

Description

Follow-up to #36190.

Steps to reproduce

  1. Install Brave from the Play Store on Chromebook
  2. Launch Brave
  3. Hamburger menu > Settings > Sync
  4. Sart new sync or connect to the existing sync
  5. When a device is in the sync chain already, tap Sync options
  6. Enable Passwords toggle switch > Observe

Actual result

Passwords can't be synced/enabled on Chromebook.

I tried it on a Chromebook without biometrics (fingerprint/face unlock) options. I was able to use only the Gmail account password and PIN unlock which can be set in OS settings.

2.mov

Expected result

The user must be able to enable Passwords in the sync chain using the PIN or Password device unlock method.

Reproduces how often

Easily reproduced

Brave version

Brave build: 1.73.100
Chromium: 131.0.6778.108 (Official Build) (64-bit)

Device

  • Brand/Model: Acer CX5400 / ChromeOS 130.0.6723.126 (Official Build) (64-bit)
  • Android version: 13

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@hffvld hffvld mentioned this issue Dec 11, 2024
Closed
@VTArxelus
Copy link

Same Issue here, will be attaching pictures of information that may be helpful. Did not see 1.73.100, but did find what I assume is the relevant nightly.

Screenshot 2024-12-10 22.56.42.png

Screenshot 2024-12-10 22.59.39.png

@sw-samuraj
Copy link

sw-samuraj commented Dec 11, 2024 •
edited
Loading

The same issue on the mobile phone with Android 14 (Build/U1RDS34.80-40-3). The password switch stays disabled after authentication and it can't be enabled. Brave 1.73.97, Chromium 131.0.6778.108.

Image

@VTArxelus
Copy link

The same issue on the mobile phone with Android 14 (Build/U1RDS34.80-40-3). The password switch stays disabled after authentication and it can't be enabled. Brave 1.73.97, Chromium 131.0.6778.108.

Image

You need to make a separate issue. This issue is for ChromeOS.

@hffvld
Copy link
Contributor Author

hffvld commented Dec 11, 2024

This issue should be resolved for Android devices with Brave 1.73.100 which will be available in Play Store soon.

@VTArxelus
Copy link

Still Broken on 1.73.101.Screenshot 2024-12-13 18.23.25.png

Screenshot 2024-12-13 18.24.00.png

@AlexeyBarabash
Copy link
Contributor

I was able to reproduce it at ChromeOS emulator

AlexeyBarabash added a commit to brave/brave-core that referenced this issue Dec 18, 2024
@AlexeyBarabash
Do not require screenlock on ChromeOS for passwords sync
b0e3f34 
Fixes brave/brave-browser#42816
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Dec 18, 2024
@AlexeyBarabash
Do not require screenlock on ChromeOS for passwords sync
d0991f5 
Fixes brave/brave-browser#42816
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Dec 18, 2024
@AlexeyBarabash
Do not require screenlock on ChromeOS for passwords sync
0b00142 
Fixes brave/brave-browser#42816
@AlexeyBarabash AlexeyBarabash linked a pull request Dec 18, 2024 that will close this issue
Draft
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
bug feature/sync OS/ChromeOS QA/Yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not require screenlock on ChromeOS for passwords sync brave/brave-core
5 participants
@sw-samuraj @AlexeyBarabash @VTArxelus @hffvld and others